Introduce scalaShadowing package #1617
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `scalaShadowing` package is used to safely modify classes and objects in scala so that they can be used from dotty. They will be visible as members of the `scala` package, replacing any objects or classes with the same name. But their binary artifacts are in `scalaShadowing` so they don't clash with the same-named `scala` members at runtime.
|
LGTM and it fixed the issue in #1479. |
- Remove unused classes Pair and Singleton. - Move classes from dotty.annotation.internal to scala.annotation.internal. The only classes remaining now are in dotty.runtime and DottyPredef. We should probably do something about them as well at some point.
|
I assume that we could also shadow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
scalaShadowingpackage is used to safely modify classes andobjects in scala so that they can be used from dotty. They will
be visible as members of the
scalapackage, replacing any objectsor classes with the same name. But their binary artifacts are
in
scalaShadowingso they don't clash with the same-namedscalamembers at runtime.
Review by @nicolasstucki